Repository navigation
Set Content-Length for tile responses (fixes chunked encoding for gzipped tiles) - #283
Merged
Merged
Conversation
Member
|
Thanks for the enhancement and test case. I released version 1.31.2 with the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the
Content-Lengthheader for tile responses. NormallyServeContentwould set theContent-Lengthheader, but a commit in thenet/httppackage 3 years ago changed that for responses withContent-Encodingset.But for pmtiles, the content is already gzipped, and we are just passing it, so not setting
Content-Lengthdoesn't make sense for us, especially that it breaks things like Cloudflare CDN which relies onContent-Lengthheader being present to cache anything in its reserve.Diff:
https://github.com/golang/go/blob/master/src/net/http/fs.go#L399-L426