Skip to content

Support PEP 696 - #4327

Merged
hauntsaninja merged 5 commits into
psf:mainfrom
JelleZijlstra:pep696
Apr 24, 2024
Merged

hauntsaninja merged 5 commits into
psf:mainfrom
JelleZijlstra:pep696

Conversation

@JelleZijlstra

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Apr 24, 2024 •

Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (57fe1e1) to main (2f88085).


What is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some more test cases. These may be preexisting, but:

  • I think I'd prefer if simple / longer split the arguments instead of the generic part.
  • The formatting in trailing_comma2 looks buggy to me

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have an issue for those too :-)

@JelleZijlstra

Copy link
Copy Markdown
Collaborator Author

Yes, #4071 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants