Skip to content

Updated nids for SysclibForKernel - #334

Merged
sharkwouter merged 3 commits into
pspdev:masterfrom
krazynez:master
Jan 3, 2026
Merged

sharkwouter merged 3 commits into
pspdev:masterfrom
krazynez:master

Conversation

@krazynez

Copy link
Copy Markdown
Contributor

Cross referenced with uOFW src

Comment thread src/kernel/SysclibForKernel.S Outdated
#endif
#ifdef F_SysclibForKernel_0040
IMPORT_FUNC "SysclibForKernel",0x909C228B,setjmp
IMPORT_FUNC "SysclibForKernel",0xC2145E80,snprintf

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this switched ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move it down, was putting it near sprintf, also need to update the Makefile.am to add the missing F_SysclibForKernel_ function for snprintf or the offset. Just noticed that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually keeping diffs minimal is the best course of action (i.e. leave the existing longjmp/setjmp blocks as they were)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay no prob I will append it to the bottom 👍

@sharkwouter
sharkwouter merged commit b4a2b96 into pspdev:master Jan 3, 2026
1 check passed
@sharkwouter

Copy link
Copy Markdown
Member

Hey @krazynez, sorry I forgot about this one. I've merged it now.

@krazynez

krazynez commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

Hey @krazynez, sorry I forgot about this one. I've merged it now.

No worries 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants