Repository navigation
libcglue: clarify resetting newlib stdio init in __locks_init - #357
Merged
Merged
Conversation
Longer description (optional): Clarify the reason for clearing _REENT_CLEANUP(_REENT) in __locks_init so that readers understand this forces newlib to treat stdio as uninitialized and re-create FILE structures and their locks on next use.
sharkwouter
approved these changes
Mar 11, 2026
sharkwouter
left a comment
sharkwouter
left a comment
Member
There was a problem hiding this comment.
Hey @fjtrujy, sorry for not finding the time to look at this on the weekend. I tested this now and I didn't notice a difference, which is a good thing. I'll merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Longer description (optional):
Clarify the reason for clearing _REENT_CLEANUP(_REENT) in __locks_init so that readers understand this forces newlib to treat stdio as uninitialized and re-create FILE structures and their locks on next use.