Repository navigation
Reject NULL / uninitialised mutex handles with EINVAL - #3
Merged
sharkwouter merged 1 commit intoMay 12, 2026
Merged
sharkwouter merged 1 commit into
sharkwouter merged 1 commit into
Conversation
The mutex API previously dereferenced *mutex unconditionally, relying
on the OS to convert a bad load into an error. On the embedded targets
this library runs on (PS2 EE, PSP, Vita) there is no signal handling
for bad loads — the kernel traps and the process dies, so the API
itself has to validate the pointer.
Make pthread_mutex_{lock,trylock,timedlock,unlock,destroy} reject both
mutex == NULL and *mutex == NULL with EINVAL. Add tests/mutex9.c to
cover both NULL handles and the post-failed-init NULL value case.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
3 tasks
sharkwouter
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pthread_mutex_{lock,trylock,timedlock,unlock,destroy}rejectmutex == NULLand*mutex == NULLwithEINVALinstead of dereferencing.tests/mutex9.cexercising both NULL handles and the post-failed-init NULL-value case across all five mutex APIs.Test plan
pthread_test_mutex9()passes.pthread_test_mutex9()passes.