Repository navigation
Update clone command, fail cloning of path deps - #225
Merged
Merged
Conversation
micprog
force-pushed
the
clone_cleanup
branch
from
November 7, 2025 12:22
0e27e28 to
b4d7a92
Compare
phsauter
reviewed
Nov 10, 2025
micprog
force-pushed
the
clone_cleanup
branch
from
December 4, 2025 17:03
b4d7a92 to
20c5278
Compare
fischeti
reviewed
Dec 5, 2025
fischeti
left a comment
fischeti
left a comment
Contributor
There was a problem hiding this comment.
I tried it out on an example that is similar to what is described in #208. However, I get the following behaviour:
bender clone Astill works, and it does not update the path ofBin Bender.lock i.e. it still points to the one in.bender. Which I think is fine.bender clone Bthrows an error, but not the new one I would expect i.e. I get afatal: '".bender/path/to/path_dep"' does not appear to be a git repository
Shouldn't the second case throw the new errorDependency is not a git dependency, cannot clone.?
micprog
force-pushed
the
clone_cleanup
branch
from
December 10, 2025 14:07
8880af2 to
9386e3e
Compare
Member
Author
I updated the implementation to properly handle 1., i.e., also redirecting the dependency path for path dependencies in git dependencies. I was not able to reproduce 2. |
fischeti
approved these changes
Dec 11, 2025
fischeti
left a comment
fischeti
left a comment
Contributor
There was a problem hiding this comment.
I retried and both scenarios now do what they are meant to do👍
micprog
force-pushed
the
clone_cleanup
branch
from
December 11, 2025 15:28
89c8b92 to
cc12d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208