Skip to content

Add metadata information to script output - #244

Merged
micprog merged 4 commits into
pulp-platform:masterfrom
tenstorrent:metadata
Jan 12, 2026
Merged

micprog merged 4 commits into
pulp-platform:masterfrom
tenstorrent:metadata

Conversation

@mrogenmoserTT

Copy link
Copy Markdown
Contributor

No description provided.

@fischeti fischeti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/cmd/script.rs
let mut all_defines = IndexMap::new();
let mut all_incdirs = vec![];
let mut all_files = vec![];
let mut all_files = IndexSet::new();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I was just wondering whether duplicate files caused any problems before

@micprog

micprog commented Jan 12, 2026

Copy link
Copy Markdown
Member

CI fails as the script output has changed with added comments for metadata. This is intended.

@micprog
micprog merged commit cf3bd15 into pulp-platform:master Jan 12, 2026
7 of 9 checks passed
@mrogenmoserTT
mrogenmoserTT deleted the metadata branch January 12, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants