Repository navigation
Conversation
fischeti
reviewed
Jan 12, 2026
fischeti
left a comment
fischeti
left a comment
Contributor
There was a problem hiding this comment.
LGTM in general, I like this feature❤️
One CLI regression test is currently failing, not sure if this is expected or not. Also we could add a few examples to the test list. Of course, they are expected to fail now.
| let mut target_defs = all_targets | ||
| .into_iter() | ||
| .filter_map(|t| match t.contains(':') { | ||
| true => None, |
Contributor
There was a problem hiding this comment.
What is the idea here? If I understand it correctly all_targets are now stripped of the dependency, so this should never happen?
Member
Author
There was a problem hiding this comment.
Yes, I'll remove this filtering!
fischeti
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.