Repository navigation
Added conditional compilation for symlink removal in cli and clone - #252
Merged
micprog merged 2 commits intoJan 19, 2026
Merged
Conversation
micprog
reviewed
Jan 19, 2026
micprog
left a comment
micprog
left a comment
Member
There was a problem hiding this comment.
Thank you for finding this issue and proposing a fix! Unfortunately, we don't test Windows as extensively. I proposed some minor adjustments to simplify the design, but should be OK otherwise!
micprog
force-pushed
the
fix/windows-remove-symlink
branch
from
January 19, 2026 15:53
0391610 to
13d5e75
Compare
micprog
approved these changes
Jan 19, 2026
micprog
left a comment
micprog
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates and fixes! LGTM! I ran cargo fmt and rebased to simplify merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of symlinks is now handled differently for Unix and Windows:
std::fs::remove_file()std::fs::remove_dir()instead.See [bug] Fails to remove symlink on windows #251 for issue