Skip to content

Remove derived JSON instances for Type #3494

Description

@natefaubion

#3484 added annotations to Type which technically breaks compatibility since the JSON instances are derived. We should remove these and do something similar to what we've done with the Kind codecs before the next release.

Activity

  1. hdgarrood commented on Dec 21, 2018

    @hdgarrood
    Contributor

    refs #2655

  2. natefaubion commented on Dec 23, 2018

    @natefaubion
    ContributorAuthor

    What is the status on using aeson-better-errors vs just aeson? The kind codecs use better-errors, but things like corefn just use aeson. Is there a preference?

  3. hdgarrood commented on Dec 23, 2018

    @hdgarrood
    Contributor

    aeson-better-errors only deals with the parsing direction; I think we generally use standard aeson for producing json, and aeson-better-errors for parsing it. The ide code seems to use standard aeson for both directions, though. There's not any huge reason to prefer one over the other these days, I don't think, as a little while after I first released aeson-better-errors, aeson's own errors improved to be more or less on par with it. The one thing I would say is that I think aeson-better-errors' API is a bit better suited for hand-written instances.

  4. added a commit that references this issue on Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions