Repository navigation
Add value source positions - #2427
Merged
Merged
Conversation
Contributor
|
Looks good to me, thanks! |
Contributor
Author
|
So this might be better if operators actually work as well as giving improved source spans! Tests should hopefully now pass |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a few errors with overgenerous source spans listed in #1801 - specifically
UnknownNamefor data constructors, identifiers and operators.(I previously tried to add this for value atoms for source maps, at which point it broke something, though tests at least seem to pass now).