Skip to content

Allow aeson 1.1 - #2873

Merged
paf31 merged 1 commit into
purescript:masterfrom
felixonmars:patch-2
Jun 20, 2017
Merged

paf31 merged 1 commit into
purescript:masterfrom
felixonmars:patch-2

Conversation

@felixonmars

Copy link
Copy Markdown
Contributor

It seems to work fine here.

It seems to work fine here.
@hdgarrood

Copy link
Copy Markdown
Contributor

We've been bitten in the past by making changes like this which seemed to work without really testing properly. We really need to check the aeson release notes before doing this, e.g. to make sure that no instances we are using have been changed.

@paf31

paf31 commented May 4, 2017

Copy link
Copy Markdown
Contributor

Now might be a good time to add those JSON unit tests we discussed recently.

@hdgarrood

Copy link
Copy Markdown
Contributor

If we were using derived instances and checking a hash based on the data type definition, and Aeson's TH instance derivation changed, a bug could still slip through that way though surely?

@kritzcreek

Copy link
Copy Markdown
Member

After reading through the aeson's changelog I didn't see anything breaking for us. Every new addition defaults to backwards compatible behaviour.

@paf31
paf31 merged commit 70a87d4 into purescript:master Jun 20, 2017
@paf31

paf31 commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

Thanks @kritzcreek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants