Repository navigation
Allow aeson 1.1 - #2873
Merged
Merged
Allow aeson 1.1#2873
Conversation
It seems to work fine here.
Contributor
|
We've been bitten in the past by making changes like this which seemed to work without really testing properly. We really need to check the aeson release notes before doing this, e.g. to make sure that no instances we are using have been changed. |
Contributor
|
Now might be a good time to add those JSON unit tests we discussed recently. |
Contributor
|
If we were using derived instances and checking a hash based on the data type definition, and Aeson's TH instance derivation changed, a bug could still slip through that way though surely? |
Member
|
After reading through the aeson's changelog I didn't see anything breaking for us. Every new addition defaults to backwards compatible behaviour. |
Contributor
|
Thanks @kritzcreek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to work fine here.