Repository navigation
[purs ide] extract namespace adt - #2878
Conversation
|
👍 LGTM |
|
Would it make sense to unify this with the equivalent type in Language.PureScript.Docs? |
|
@hdgarrood but where would the type live? I guess in one of the |
|
I think Names might be more appropriate? Is the Ide code not able to depend on Docs at the moment though? |
|
I think I'll leave this PR as is for now. I think it totally makes sense to have this Enum somewhere in the compiler, but it's probably not only Docs and Ide that would use it. |
Doesn't sound good, but seems to be related to getting the git revision on the AppVeyor instance? Definitely isn't caused by this PR. |
|
Oh dear :/ Might be worth trying to repro with a local Windows VM, and perhaps seeing what happens with GHC HEAD too? I found this patch which was recently merged https://ghc.haskell.org/trac/ghc/ticket/13108#no1 which slightly improves this error message we're seeing. |
|
The tests works just fine on my local Windows machine. Must be something AppVeyor specific. |
|
I suppose there's a possibility it's due to us running |
|
Still doesn't break anything on my machine. I'll just merge this PR since it doesn't cause the failures and I'll open a separate issue for the CI failures? |
|
Sounds good to me. |
This is just a minor refactoring in preparation for #2792.