Skip to content

[purs ide] extract namespace adt - #2878

Merged
kritzcreek merged 2 commits into
purescript:masterfrom
kritzcreek:purs-ide-extract-namespace-adt
May 10, 2017
Merged

kritzcreek merged 2 commits into
purescript:masterfrom
kritzcreek:purs-ide-extract-namespace-adt

Conversation

@kritzcreek

Copy link
Copy Markdown
Member

This is just a minor refactoring in preparation for #2792.

@kritzcreek kritzcreek changed the title Purs ide extract namespace adt [purs ide] extract namespace adt May 10, 2017
@paf31

paf31 commented May 10, 2017

Copy link
Copy Markdown
Contributor

👍 LGTM

@hdgarrood

Copy link
Copy Markdown
Contributor

Would it make sense to unify this with the equivalent type in Language.PureScript.Docs?

@kritzcreek

Copy link
Copy Markdown
Member Author

@hdgarrood but where would the type live? I guess in one of the AST modules?

@hdgarrood

Copy link
Copy Markdown
Contributor

I think Names might be more appropriate? Is the Ide code not able to depend on Docs at the moment though?

@kritzcreek

kritzcreek commented May 10, 2017 •

Copy link
Copy Markdown
Member Author

I think I'll leave this PR as is for now. I think it totally makes sense to have this Enum somewhere in the compiler, but it's probably not only Docs and Ide that would use it.

@kritzcreek

Copy link
Copy Markdown
Member Author
[ 2 of 14] Compiling Version          ( app\Version.hs, .stack-work\dist\ca59d0ab\build\purs\purs-tmp\Version.o )
Segmentation fault/access violation in generated code

Doesn't sound good, but seems to be related to getting the git revision on the AppVeyor instance? Definitely isn't caused by this PR.

@hdgarrood

Copy link
Copy Markdown
Contributor

Oh dear :/ Might be worth trying to repro with a local Windows VM, and perhaps seeing what happens with GHC HEAD too? I found this patch which was recently merged https://ghc.haskell.org/trac/ghc/ticket/13108#no1 which slightly improves this error message we're seeing.

@kritzcreek

Copy link
Copy Markdown
Member Author

The tests works just fine on my local Windows machine. Must be something AppVeyor specific.

@hdgarrood

Copy link
Copy Markdown
Contributor

I suppose there's a possibility it's due to us running stack slightly differently locally and on AppVeyor? Eg, does it make a difference if you run with --jobs=1 like CI does?

@kritzcreek

Copy link
Copy Markdown
Member Author

Still doesn't break anything on my machine. I'll just merge this PR since it doesn't cause the failures and I'll open a separate issue for the CI failures?

@hdgarrood

Copy link
Copy Markdown
Contributor

Sounds good to me.

@kritzcreek
kritzcreek merged commit 21bd77f into purescript:master May 10, 2017
@kritzcreek
kritzcreek deleted the purs-ide-extract-namespace-adt branch May 10, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants