Extend cholesky of triangular dot rewrite to matmul Ops - #459
Merged
Merged
Conversation
ricardoV94
added
bug
This reverts commit a708732.
ricardoV94
force-pushed
the
tweak_chol_dot_rewrite
branch
from
September 26, 2023 12:06
5d7e3cb to
c996ce1
Compare
jessegrabowski
left a comment
jessegrabowski
left a comment
Member
There was a problem hiding this comment.
Looks good pending that you check the typo on ndim in the unittest
Also restrict to 2D Dot cases
ricardoV94
force-pushed
the
tweak_chol_dot_rewrite
branch
from
September 27, 2023 15:58
c996ce1 to
c06fdb0
Compare
ricardoV94
marked this pull request as ready for review
September 27, 2023 15:59
11 of 50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also restrict to 2D Dot cases
Also reverts #455