Skip to content

Update ContourPy to 1.2.0 - #4291

Merged
hoodmane merged 5 commits into
pyodide:mainfrom
ianthomas23:contourpy_1.2.0
Nov 14, 2023
Merged

hoodmane merged 5 commits into
pyodide:mainfrom
ianthomas23:contourpy_1.2.0

Conversation

@ianthomas23

@ianthomas23 ianthomas23 commented Nov 12, 2023 •

Copy link
Copy Markdown
Contributor

Update ContourPy to the latest release, 1.2.0. This uses meson and meson-python to build, and following the recent improvements to meson-based builds here, such as the automagic use of emscripten.meson.cross, this was really easy.

To use pybind11 with clang >= 17 we need pybind/pybind11#4767. This isn't in a pybind11 release yet, so I have included a patch to install pybind11 direct from the github commit that includes the PR. This patch can be removed after the next pybind11 release.

@hoodmane hoodmane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianthomas23, CI looks good (failures are known flakes).

@ryanking13

ryanking13 commented Nov 14, 2023 •

Copy link
Copy Markdown
Member

This uses meson and meson-python to build, and following the recent improvements to meson-based builds here, such as the automagic use of emscripten.meson.cross, this was really easy.

It is good to hear that meson build works well :)

@hoodmane

Copy link
Copy Markdown
Member

Thanks again @ianthomas23!

@hoodmane
hoodmane merged commit ca6d633 into pyodide:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants