Repository navigation
Non-http(s) URLs used in project_urls are rejected as invalid #10198
Description
Describe the bug
I recently updated one of my packages to have a few project_urls, including website, issue tracker and IRC. For the latter, I used a URL in the format of irc://example.com/#my-channel, which Firefox and other tools understand.
Expected behavior
Uploading the package should have worked find.
To Reproduce
Try uploading a package with:
project_urls={
"Chat": "irc://example.com/#my-channel",
# ...
},My Platform
I used twine to upload the package via GitHub Actions.
I've pinpointed the issue down to this snippet, which tries to validate the URL as http or https, even in cases where it's a different schema.
Additional context
I suspect that the validation is mostly an oversight of not taking this edge-case in mind; I can't imagine there was a strong reason to disallow non-https URLs.
While I think there's definitely value in allowing them, in case there's a strong sentiment against this, it would at least make sense for the error message to be clearer. It was quite tricky for me to figure out exactly what the error was, since right now the validation response just says Use valid URL., without even indicating which URL is wrong or in what way.
Activity
di commentedon Feb 18, 2022
I think I'd prefer for us to stick with valid HTTP/HTTPS links, since these go in the sidebar for the project, and other protocols are somewhat exotic.
I'd be in favor of updating the error message here to indicate that this needs to be a valid HTTP/HTTPS URL.
WhyNotHugo commentedon Feb 18, 2022
di commentedon Feb 18, 2022
Unfortunately that would require an update to the Core metadata spec
Which I'm now noting says:
Which IMO reinforces that this must remain HTTP/HTTPS.
WhyNotHugo commentedon Feb 18, 2022
dstufft commentedon May 23, 2023
I'm going to close this. I think that keeping these as HTTP(S) urls is the path we're going to go for here, and if people feel strongly it's probably best to discuss it on discuss.python.org.