Repository navigation
Fix OSError in tmpdir on emscripten due to missing getuid() - #10766
Merged
Merged
Conversation
nicoddemus
reviewed
Feb 28, 2023
nicoddemus
reviewed
Feb 28, 2023
Member
|
Thanks @rdb! FYI decided to move the uid-handling logic to a separate function in Would appreciate a second set of eyes reviewing the change. 👍 |
nicoddemus
reviewed
Feb 28, 2023
|
|
||
|
|
||
| def legacy_path(path: Union[str, "os.PathLike[str]"]) -> LEGACY_PATH: | ||
| def legacy_path(path: str | os.PathLike[str]) -> LEGACY_PATH: |
Member
There was a problem hiding this comment.
Note: type annotation changes were introduced by pyupgrade because I added the from __future__ import annotations import.
nicoddemus
force-pushed
the
fix-10765
branch
from
February 28, 2023 14:22
9cf64d7 to
cb9e8be
Compare
nicoddemus
approved these changes
Feb 28, 2023
nicoddemus
added
the
needs backport
Contributor
Author
|
Thanks. Seems fine, I built with your changes and our test suite is still passing. |
Zac-HD
approved these changes
Mar 5, 2023
Zac-HD
left a comment
Zac-HD
left a comment
Member
There was a problem hiding this comment.
Looks good to me, let's merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten defines
getuid()as a stub that always returns 0. This change is necessary for our unit testing suite to pass under node.js.Have no need to be added to AUTHORS for such a trivial change.
Closes #10765