Skip to content

Full in pyproject.toml and Poetry - #289

Merged
BeyondEvil merged 2 commits into
pytest-dev:masterfrom
BeyondEvil:switch-to-pyproject
Mar 28, 2022
Merged

BeyondEvil merged 2 commits into
pytest-dev:masterfrom
BeyondEvil:switch-to-pyproject

Conversation

@BeyondEvil

Copy link
Copy Markdown
Contributor

No description provided.

@BeyondEvil
BeyondEvil force-pushed the switch-to-pyproject branch 2 times, most recently from ad0dd8d to 2efcde2 Compare March 27, 2022 21:14
@BeyondEvil
BeyondEvil requested a review from isaulv March 27, 2022 23:44
@BeyondEvil

Copy link
Copy Markdown
Contributor Author

Hey @isaulv

Trying to get back into this.

Would be nice with a second pair of eyes on this. Not sure what the Windows failures are about.

isaulv
isaulv previously approved these changes Mar 28, 2022

@isaulv isaulv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaulv

isaulv commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

@BeyondEvil I think the Windows tests are failing due to the driver dying somewhere. Those url lib failures look like the driver has stopped responding or crashed.

@BeyondEvil

Copy link
Copy Markdown
Contributor Author

@BeyondEvil I think the Windows tests are failing due to the driver dying somewhere. Those url lib failures look like the driver has stopped responding or crashed.

It's always the same tests.

Also, any idea why the testingbot test fails?

@BeyondEvil
BeyondEvil force-pushed the switch-to-pyproject branch from 1ceb193 to 8a45d8c Compare March 28, 2022 12:37
@BeyondEvil
BeyondEvil merged commit 7371e52 into pytest-dev:master Mar 28, 2022
@BeyondEvil
BeyondEvil deleted the switch-to-pyproject branch March 28, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants