Repository navigation
Add support for Django client driver - #146
Merged
michelts merged 16 commits intoJun 6, 2020
Merged
Conversation
This is the result of the django-admin startproject django_sample_project, without any modification.
If we reach admin, we can assume django is working!
This is an attempt to avoid the failing tests.
This way, we can opt out of pytest-django.
Python 2.7 accepts Django 1.11 at last, so the sample project needs to be compatible with both.
bubenkoff
requested changes
Jun 5, 2020
bubenkoff
left a comment
bubenkoff
left a comment
Member
There was a problem hiding this comment.
please address
please also add a changelog record
bubenkoff
approved these changes
Jun 6, 2020
Contributor
Author
|
Done! Thank you @bubenkoff |
bubenkoff
previously approved these changes
Jun 6, 2020
Member
|
@michelts added you to the repo, please merge by squashing the commits into one |
bubenkoff
approved these changes
Jun 6, 2020
Member
|
@michelts released 2.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The splinter API is very useful to traverse over a Django client response body, but there is a minor bug that prevents one to use django as driver with pytest-splinter.
I fixed the bug and added a test for it.
Let me know if I missed anything!