Py_SetFatalErrorAbortFunc: Allow embedding program to handle fatal errors #74745

Activity

1. thp commented on Jun 3, 2017

   

   thpmannequin

   on Jun 3, 2017

   MannequinAuthor

   More actions

   In our application that embeds a Python interpreter, we had the issue that certain system configurations (namely, a lone "libpython27.dll" without any standard library) caused silent failures (note that this is using Python 2.7, but Python 3.x would be similarly affected, as the Py_FatalError() handling is still the same):

   gpodder/gpodder#286

   There exists a Stack Overflow thread about this:

   https://stackoverflow.com/questions/7688374/how-to-i-catch-and-handle-a-fatal-error-when-py-initialize-fails

   The workaround described therein is:

   "I solved this by creating a separate executable that attempts to initialize python. My primary process will launch it and check the exit code and only call PyInitialize if the child process was successful. So, python is initialized twice, but it is better than an apparent crash to the user."

   So, what if instead we allow the embedding program to set a function pointer to a function that will get called instead of abort()? We have to make clear in the docs that after this function is called, the Python interpreter cannot be used, and the application should probably exit, but at least it would allow applications to capture the error message and show it to the user (e.g. using a MessageBox() on Windows) before exiting -- see attached patch.

   Any alternative solutions would be fine as well that don't require us to create a new process and "try to" Py_Initialize() there, especially since Py_FatalError() might potentially be called in other places and in all those cases, a user-visible dialog would be better than an apparent "crash" (application exits).
2. thp

   added

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   on Jun 3, 2017
3. thp commented on Jun 3, 2017

   

   thpmannequin

   on Jun 3, 2017

   MannequinAuthor

   More actions

   Quick fix for the patch: Of course, the line with abort() needs to be removed before this block:

   + if (_fatal_error_abort_func != NULL) {
   + _fatal_error_abort_func(msg);
   + } else {
   + abort();
   + }
4. vstinner commented on May 27, 2019

   

   vstinner

   on May 27, 2019

   Member

   More actions

   The issue has been fixed in bpo-36763 with the implementation of the PEP-587. A new API now allow to handle Python initialization error with a new PyStatus structure.

   By the way, bpo-1195571 was a similar issue.
5. vstinner

   closed this as completedon May 27, 2019
6. vstinner commented on May 27, 2019

   

   vstinner

   on May 27, 2019

   Member

   More actions

   Note: if I misunderstood the issue, please open it ;-)
7. ezio-melotti

   transferred this issue fromon Apr 10, 2022