support platform and version checks in conditional expressions #5671

Activity

1. emmatyping commented on Sep 25, 2018

   

   emmatyping

   on Sep 25, 2018

   Member

   More actions

   We do support platform and version checks, but only sys.platform and sys.version_info. Considering six is used a fair amount for Python2/3 straddling code, I think we should also support it.
2. emmatyping

   added

   feature

   needs discussion

   priority-1-normal

   on Sep 25, 2018
3. benjaminp commented on Sep 25, 2018

   

   benjaminp

   on Sep 25, 2018

   Last edited by benjaminp

   Author

   More actions

   Ah, sorry, I didn't mean this to be about six. There's the same problem with sys.version_info[0] == 3.
4. emmatyping commented on Sep 25, 2018

   

   emmatyping

   on Sep 25, 2018

   Last edited by emmatyping

   Member

   More actions

   Ah, interesting, with this:

   import sys
   import os
   reveal_type(os.environb if sys.version_info > (3, 0, 0) else os.environ)
   

   This reveals builtins.object on Python 3 and gives an attribute error on Python 2 (since os.environb doesn't exist). This does indeed seem to be a bug.
5. emmatyping

   added

   bugmypy got something wrongmypy got something wrong

   priority-0-high

   and removed

   feature

   priority-1-normal

   on Sep 25, 2018
6. gvanrossum commented on Sep 25, 2018

   

   gvanrossum

   on Sep 25, 2018

   Member

   More actions

   (OT: six.PY3 support is easy: just pass --always-true=PY3.)

   👍React with 👍1Reacted by Emma Smith
7. ilevkivskyi commented on Sep 26, 2018

   

   ilevkivskyi

   on Sep 26, 2018

   Member

   More actions

   This is a duplicate of #5550.

   I will raise the priority of that issue (but still not high probably, since there is a simple workaround).
8. ilevkivskyi

   closed this as completedon Sep 26, 2018