Remove @builtinclass #599

Activity

1. JukkaL

   added

   task

   topic-pep-484

   on Mar 14, 2015
2. elazarg commented on Oct 17, 2016

   

   elazarg

   on Oct 17, 2016

   Contributor

   More actions

   If I am not mistaken, it can be removed right now. No test demonstrate a need for it.

   The only use of this information inside mypy (through ClassDef.is_builtinclass) is in nearest_builtin_ancestor(), called from check_multiple_inheritance() in checker.py[1]. Replacing

   -        if base.defn.is_builtinclass:
   +        if base.defn.fullname == 'builtins.object':

   passes all the tests[2], except the whitebox-test testBuiltinclassDecorator in semanal-classes.test, but this test only verifies that the implementation tracks this information.

   [1] It resides on meet.py, for some reason, adding an unnecessary dependency
   [2] Otherwise it could be replaced with looking up the decorator. Or keeping a list of builtin classes
3. gnprice commented on Oct 20, 2016

   

   gnprice

   on Oct 20, 2016

   Collaborator

   More actions

   Thanks for investigating! Sounds like a small patch with that cleanup would be great.
4. gvanrossum

   added this to the 0.5This milestone has been deleted milestone on Oct 20, 2016
5. gvanrossum

   added a commit that references this issue on Oct 22, 2016

   Remove support for @builtinclass (#2294)

   ...

   2e19181
6. gvanrossum commented on Oct 22, 2016

   

   gvanrossum

   on Oct 22, 2016

   Member

   More actions

   Let's leave this open until it's also removed from typeshed (two lines).
7. gvanrossum

   closed this as completedon Oct 22, 2016