Support type information from conditional expressions #806

Activity

1. JukkaL

   added

   bugmypy got something wrongmypy got something wrong

   hack

   on Aug 18, 2015
2. JukkaL

   removed

   hack

   on Oct 10, 2015
3. JukkaL

   closed this as completedon Oct 10, 2015
4. sametmax commented on Oct 14, 2016

   

   sametmax

   on Oct 14, 2016

   More actions

   If there the same fix with if callable()? Because I got this:

       def __getitem__(self, index):
           # type: (Union[int, slice, Callable]) -> Union[IterableWrapper, Any]
   
           if isinstance(index, int):
               return at_index(self.iterator, index)
   
           if callable(index):
               return first_true(self.iterator, index) 
   
           start = index.start or 0
           step = index.step or 1
           stop = index.stop
   

   And mypy complains that index may not have a start attribute.
5. rwbarton commented on Oct 14, 2016

   

   rwbarton

   on Oct 14, 2016

   Contributor

   More actions

   I think adding this kind of logic with if callable(x): has come up before in this issue tracker. It should be easy to do (with the provision that mypy currently only understands that Callable things are callable, but not in general instances with __call__ methods; but that should be sufficient in your example).
6. gvanrossum commented on Oct 14, 2016

   

   gvanrossum

   on Oct 14, 2016

   Member

   More actions

   Yeah, adding callable() is #1973. Better support for __call__ is #797.

   On Fri, Oct 14, 2016 at 5:53 AM, Reid Barton [email protected]
   wrote:

   I think adding this kind of logic with if callable(x): has come up before
   in this issue tracker. It should be easy to do (with the provision that
   mypy currently only understands that Callable things are callable, but
   not in general instances with call methods; but that should be
   sufficient in your example).

   —
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on GitHub
   #806 (comment), or mute
   the thread
   https://github.com/notifications/unsubscribe-auth/ACwrMq0sBStYWXKaDvREt3fyUIWvdpx8ks5qz3svgaJpZM4Ft1q_
   .

   --Guido van Rossum (python.org/~guido)

   👍React with 👍1Reacted by sametmax