Stop looking for .gitignore at top level of working tree - #20775
Merged
Merged
Conversation
I have a checkout where I'm using the new `exclude_gitignore` facility introduced in python#18696, and where a parent directory has a `.gitignore` file that happens to match the full path of the checkout. I just spent quite some time being very confused about why mypy reported success despite the code having obvious typing errors. Unlike git itself, mypy didn't stop looking for `.gitignore` files at the top level of the working tree; now it does.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Feb 9, 2026
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
OK, if this is how this behaves, we should match that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a checkout where I'm using the new
exclude_gitignorefacility introduced in #18696, and where a parent directory has a.gitignorefile that happens to match the full path of the checkout. I just spent quite some time being very confused about why mypy reported success despite the code having obvious typing errors. Unlike git itself, mypy didn't stop looking for.gitignorefiles at the top level of the working tree; now it does.