Skip to content

Allow tuples as second argument to namedtuple - #2262

Merged
gvanrossum merged 5 commits into
python:masterfrom
alexjurkiewicz:namedtuple-tuple-args
Oct 17, 2016
Merged

gvanrossum merged 5 commits into
python:masterfrom
alexjurkiewicz:namedtuple-tuple-args

Conversation

@alexjurkiewicz

Copy link
Copy Markdown
Contributor

Thanks to @rwbarton on IRC for pointers

@gvanrossum

gvanrossum commented Oct 17, 2016 via email

Copy link
Copy Markdown
Member

@alexjurkiewicz

Copy link
Copy Markdown
Contributor Author

All good, I got there eventually!

@gvanrossum

Copy link
Copy Markdown
Member

Victory! Can you also add a test or tests to check-namedtuple.test? I'd also check that this works for typing.NamedTuple as well as for collections.namedtuple.

@alexjurkiewicz

Copy link
Copy Markdown
Contributor Author

Added three extra tests -- do these cover what you want?

On Tue, 18 Oct 2016 at 02:10 Guido van Rossum [email protected]
wrote:

Victory! Can you also add a test or tests to check-namedtuple.test? I'd
also check that this works for typing.NamedTuple as well as for
collections.namedtuple.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2262 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXKde51ABsUXfozAcRPEUlKMktJWBmYks5q04_rgaJpZM4KYKC_
.

@gvanrossum
gvanrossum merged commit 5e9cafb into python:master Oct 17, 2016
@gvanrossum

Copy link
Copy Markdown
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants