Repository navigation
Require typing module before using a Py2 interpreter for tests. - #4041
Merged
Merged
Conversation
Member
Author
|
I think the Travis failure here is some kind of flaky unrelated failure, but I'm not 100% sure. Can someone with the necessary access trigger a re-run? |
Member
Author
|
Any concerns about merging this that I can do some further testing to assuage? |
gvanrossum
requested changes
Oct 3, 2017
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Other than the formatting I think it's fine.
| '-c', | ||
| 'import sys, typing; assert sys.version_info[:2] == (2, 7)' | ||
| ], | ||
| ).wait() |
Member
There was a problem hiding this comment.
Please don't use this incredibly stretched vertical layout; it hurts my eyes and does not help me understand the code.
Tested with: a) Python 2.7 interpreter on PATH without typing installed: Py2 subprocess tests skipped. b) Python 2.7 interpreter on PATH with typing installed: Py2 subprocess tests pass. c) Temporarily change assertion to require `(2, 6)` instead of `(2, 7)`, with no Python2.6 interpreter available (to verify that version assert works correctly): Py2 subprocess tests skipped.
carljm
force-pushed
the
check-for-py2-typing
branch
from
October 3, 2017 22:55
9c8724a to
5c5b184
Compare
Member
Author
|
Adjusted the formatting to be more vertically compact. |
gvanrossum
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4039.
Tested with:
a) Python 2.7 interpreter on PATH without typing installed: Py2 subprocess
tests skipped.
b) Python 2.7 interpreter on PATH with typing installed: Py2 subprocess tests
pass.
c) Temporarily change assertion to require
(2, 6)instead of(2, 7), withno Python2.6 interpreter available, and
typinginstalled in Python2.7 interpreteron PATH (to verify that version assert works correctly): Py2 subprocess tests skipped.