Repository navigation
Skip Python2 evaluation tests on AppVeyor - #4053
Merged
Merged
Conversation
emmatyping
changed the title
emmatyping
changed the title
gvanrossum
reviewed
Oct 3, 2017
|
|
||
|
|
||
| [case testAbs2_python2] | ||
| [case testAbs2_python2eval] |
Member
There was a problem hiding this comment.
I really would rather not have to rename all the tests to conform to this new naming convention. I think you can select for just the pythoneval tests with -k PythonEvaluationSuite, so to combine these two you can run
pytest -k "PythonEvaluationSuite and python2"
(the Windows script will require some extra quoting).
Member
Author
There was a problem hiding this comment.
Okay I will try that route.
gvanrossum
reviewed
Oct 4, 2017
| assert testcase.old_cwd is not None, "test was not properly set up" | ||
| mypy_cmdline = ['--show-traceback'] | ||
| py2 = testcase.name.lower().endswith('python2') | ||
| py2 = 'python2' in testcase.name.lower() |
Member
There was a problem hiding this comment.
I think this should be restored to exactly what it was before. I'll see if I can do the edit online myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3895
This splits the pytest run into a new command so that tests ending in
_python2evalare skipped. This is done in the appveyor.yml so that these tests still can be run locally on Windows. Hopefully, we will no longer have issues with pytest crashing the test suite after this.