Skip to content

Move linting to pytest - #5270

Closed
elazarg wants to merge 1 commit into
python:masterfrom
elazarg:pytest-flake8
Closed

elazarg wants to merge 1 commit into
python:masterfrom
elazarg:pytest-flake8

Conversation

@elazarg

@elazarg elazarg commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

Use flake8's legacy api since there's no non-legacy one.

Another item for #1673 (only stdlibsamples left).

@gvanrossum

Copy link
Copy Markdown
Member

I'm not sure I like this. Maybe running flake8 should just be a separate step in .travis.yml? That's how it is done currently -- even though runtests.py supports it, .travis.yml excludes lint (and self-check) and runs flake8 separately. I want pytest to run tests not other stuff like linters and type-checkers. (FWIW it appears self-check is no long run by .travis.yml -- something has made python runtests.py package a no-op.)

@ilevkivskyi

Copy link
Copy Markdown
Member

Maybe running flake8 should just be a separate step in .travis.yml?

I agree with this. I would just remove flake8 from runtests.py

FWIW it appears self-check is no long run by .travis.yml

One can now run pytest -k mypy_package, I am not sure I like it, I would also prefer it to be a separate Travis (and Appveyor) task actually.

@elazarg

elazarg commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

Sounds good to me. So this PR is not required at all - after stdlibsamples will be migrated, runtests.py and waiter.py can simple be removed. Is this correct?

@ilevkivskyi

Copy link
Copy Markdown
Member

after stdlibsamples will be migrated, runtests.py and waiter.py can simple be removed. Is this correct?

I think yes.

@elazarg

elazarg commented Jun 24, 2018

Copy link
Copy Markdown
Contributor Author

Closing then.

@elazarg elazarg closed this Jun 24, 2018
@gvanrossum

Copy link
Copy Markdown
Member

One can now run pytest -k mypy_package, I am not sure I like it, I would also prefer it to be a separate Travis (and Appveyor) task actually.

Yes, please.

@elazarg elazarg mentioned this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants