Repository navigation
Use Any for field type in make_dataclass - #11657
Merged
AlexWaygood merged 4 commits intoMar 25, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Can this be object instead? |
Member
|
I think Any is more appropriate because we don't really want to accept all objects. For example, ideally we'd reject |
Member
|
Yeah, I agree with Jelle. It can't actually be any object, so |
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Mar 25, 2024
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
changed the title
Any for field type in make_dataclassAny for field type in make_dataclass
Member
|
Thanks @alexei! |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11653