Python 3.5/3.6/3.7 on Appveyor

We should be testing on Python 3.5 on Appveyor. This is going to take adding the new compiler info into the config.py structures and testing it on Visual Studio 2015.

Also, we should save n days binaries of nightlies or merges to master,

Maybe this was already the case when you created the issue, but Python 3.5.0 is now up on AppVeyor.

Yes, the real issue is getting all the settings right for a build using VS2015.

@cgohlke

Seems like @cgohlke made a comment about AppVeyor recently, not sure if this is related.

Really, this time. I want this to work.

VS 2015 can be used for Python 3.5-3.7:

Python version	Visual Studio
Python 2.7	VS 2008 and VS 2010
Python 3.4	VS 2010
Python 3.5 and 3.6	VS 2015
Python 3.7 (master)	VS 2015 or VS 2017

http://pythondev.readthedocs.io/windows.html

Right now, of Python 3.x, we're only testing 3.4, and that goes EOL in 6 months (2019-03-16).

I've earlier had a look into this, but it's difficult to know what config is needed:

Pillow/winbuild/config.py

Lines 6 to 11 in fdbd719

    
           pythons = {  # '26': 7, 
        
                      '27': 7, 
        
                      'pypy2': 7, 
        
                      # '32': 7, 
        
                      '33': 7.1, 
        
                      '34': 7.1}

Pillow/winbuild/config.py

Lines 80 to 113 in fdbd719

    
           compilers = { 
        
               (7, 64): { 
        
                   'env_version': 'v7.0', 
        
                   'vc_version': '2008', 
        
                   'env_flags': '/x64 /xp', 
        
                   'inc_dir': 'msvcr90-x64', 
        
                   'platform': 'x64', 
        
                   'webp_platform': 'x64', 
        
               }, 
        
               (7, 32): { 
        
                   'env_version': 'v7.0', 
        
                   'vc_version': '2008', 
        
                   'env_flags': '/x86 /xp', 
        
                   'inc_dir': 'msvcr90-x32', 
        
                   'platform': 'Win32', 
        
                   'webp_platform': 'x86', 
        
               }, 
        
               (7.1, 64): { 
        
                   'env_version': 'v7.1', 
        
                   'vc_version': '2010', 
        
                   'env_flags': '/x64 /vista', 
        
                   'inc_dir': 'msvcr10-x64', 
        
                   'platform': 'x64', 
        
                   'webp_platform': 'x64', 
        
               }, 
        
               (7.1, 32): { 
        
                   'env_version': 'v7.1', 
        
                   'vc_version': '2010', 
        
                   'env_flags': '/x86 /vista', 
        
                   'inc_dir': 'msvcr10-x32', 
        
                   'platform': 'Win32', 
        
                   'webp_platform': 'x86', 
        
               }, 
        
           }

Does anyone have any insights?

I have created a PR for Python 3.5-3.7 - but it doesn't resolve the second comment in this issue

Brilliant, thanks and #3399 merged!

The second bit can be done with "artifacts":

https://www.appveyor.com/docs/packaging-artifacts/

https://ci.appveyor.com/project/python-pillow/pillow/settings/artifacts

They're kept for 6 months, which should be plenty. They can be copied to external storage like S3, which might be useful later, but for now AppVeyor's own storage should suffice.

Which files and folders should be included?

Hang on, we already have artifacts enabled!

Added in #1818 and #1927:

Pillow/.appveyor.yml

Lines 94 to 120 in 07645bd

    
           artifacts: 
        
           - path: pillow\dist\*.egg 
        
             name: egg 
        
           - path: pillow\dist\*.wheel 
        
             name: wheel 
        
           before_deploy: 
        
             - cd c:\pillow 
        
             - '%PYTHON%\%PIP_DIR%\pip.exe install wheel' 
        
             - cd c:\pillow\winbuild\ 
        
             - '%PYTHON%\%EXECUTABLE% c:\pillow\winbuild\build.py --wheel' 
        
             - cd c:\pillow 
        
             - ps: Get-ChildItem .\dist\*.* | % { Push-AppveyorArtifact $_.FullName -FileName $_.Name } 
        
           deploy: 
        
             provider: S3 
        
             region: us-west-2 
        
             access_key_id: AKIAIRAXC62ZNTVQJMOQ 
        
             secret_access_key: 
        
               secure: Hwb6klTqtBeMgxAjRoDltiiqpuH8xbwD4UooDzBSiCWXjuFj1lyl4kHgHwTCCGqi 
        
             bucket: pillow-nightly 
        
             folder: win/$(APPVEYOR_BUILD_NUMBER)/ 
        
             artifact: /.*egg|wheel/ 
        
             on: 
        
               APPVEYOR_REPO_NAME: python-pillow/Pillow 
        
               branch: master 
        
               deploy: YES

Here's a Pillow-5.4.0.dev0-py3.7-win32.egg and Pillow-5.4.0.dev0-cp37-cp37m-win32.whl from a recent build:

https://ci.appveyor.com/project/python-pillow/pillow/build/job/i8yyorldevfyotcr/artifacts

Navigation Menu

Repository navigation

Python 3.5/3.6/3.7 on Appveyor #1455

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pythons = { # '26': 7,
	'27': 7,
	'pypy2': 7,
	# '32': 7,
	'33': 7.1,
	'34': 7.1}

	compilers = {
	(7, 64): {
	'env_version': 'v7.0',
	'vc_version': '2008',
	'env_flags': '/x64 /xp',
	'inc_dir': 'msvcr90-x64',
	'platform': 'x64',
	'webp_platform': 'x64',
	},
	(7, 32): {
	'env_version': 'v7.0',
	'vc_version': '2008',
	'env_flags': '/x86 /xp',
	'inc_dir': 'msvcr90-x32',
	'platform': 'Win32',
	'webp_platform': 'x86',
	},
	(7.1, 64): {
	'env_version': 'v7.1',
	'vc_version': '2010',
	'env_flags': '/x64 /vista',
	'inc_dir': 'msvcr10-x64',
	'platform': 'x64',
	'webp_platform': 'x64',
	},
	(7.1, 32): {
	'env_version': 'v7.1',
	'vc_version': '2010',
	'env_flags': '/x86 /vista',
	'inc_dir': 'msvcr10-x32',
	'platform': 'Win32',
	'webp_platform': 'x86',
	},
	}

	artifacts:
	- path: pillow\dist\*.egg
	name: egg
	- path: pillow\dist\*.wheel
	name: wheel

	before_deploy:
	- cd c:\pillow
	- '%PYTHON%\%PIP_DIR%\pip.exe install wheel'
	- cd c:\pillow\winbuild\
	- '%PYTHON%\%EXECUTABLE% c:\pillow\winbuild\build.py --wheel'
	- cd c:\pillow
	- ps: Get-ChildItem .\dist\. \| % { Push-AppveyorArtifact $_.FullName -FileName $_.Name }

	deploy:
	provider: S3
	region: us-west-2
	access_key_id: AKIAIRAXC62ZNTVQJMOQ
	secret_access_key:
	secure: Hwb6klTqtBeMgxAjRoDltiiqpuH8xbwD4UooDzBSiCWXjuFj1lyl4kHgHwTCCGqi
	bucket: pillow-nightly
	folder: win/$(APPVEYOR_BUILD_NUMBER)/
	artifact: /.*egg\|wheel/
	on:
	APPVEYOR_REPO_NAME: python-pillow/Pillow
	branch: master
	deploy: YES

Python 3.5/3.6/3.7 on Appveyor #1455

Description

Activity

wiredfool commented on Oct 3, 2015

radarhere commented on Oct 15, 2015

wiredfool commented on Oct 15, 2015

aclark4life commented on Jan 5, 2017

wiredfool commented on Oct 2, 2017

hugovk commented on Jun 10, 2018

hugovk commented on Sep 19, 2018

radarhere commented on Oct 8, 2018

hugovk commented on Oct 9, 2018

hugovk commented on Oct 10, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions