Skip to content

Horizontally flip not correctly handling uint16 data #3500

Closed
Closed
Horizontally flip not correctly handling uint16 data#3500

Description

@rainbean
rainbean
opened on Dec 18, 2018

What did you do?

create an uint16 img and invoke img.transpose(Image.FLIP_LEFT_RIGHT)

What did you expect to happen?

horizontally flip the given PIL Image

What actually happened?

random data overflow

What are your OS, Python and Pillow versions?

  • OS: Ubuntu & macOS
  • Python: 3.6
  • Pillow: 5.1.0 ~ 5.3.0 tested
import numpy as np
from PIL import Image
x = np.zeros((10, 10), dtype=np.uint16)
x[1:4, 2:5] = 1
x[5:8, 5:8] = 2
y = Image.fromarray(x)
assert 2 == np.max(y)
y_ = y.transpose(Image.FLIP_LEFT_RIGHT)
assert 2 == np.max(y_) # error occurred, FLIP_TOP_BOTTOM is okay

Activity

  1. radarhere
    added
    NumPy
    on Dec 18, 2018
  2. radarhere
    changed the title [-]Horizontally flip not correctly handle uint16 data[/-] [+]Horizontally flip not correctly handling uint16 data[/+] on Dec 18, 2018

  3. surgan12 commented on Dec 20, 2018

    @surgan12
    surgan12
    on Dec 20, 2018

    Also uint16 numpy array not converting to Image

  4. radarhere commented on Jan 9, 2019

    @radarhere
    radarhere
    on Jan 9, 2019
    Member

    @surgan12 could you elaborate on what you mean? Are you able to provide a code example? I would have thought that the earlier code is doing exactly that - converting a uint16 numpy array to an image.

  5. radarhere
    closed this as completedon Jan 9, 2019
  6. radarhere
    reopened this on Jan 9, 2019

  7. radarhere commented on Jan 9, 2019

    @radarhere
    radarhere
    on Jan 9, 2019
    Member

    I've created PR #3563 to try and resolve this.

  8. radarhere
    removed
    NumPy
    on Jan 9, 2019
  9. hugovk
    closed this as completedin #3563on Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions