You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pillow 2.4 passes all tests on CPython 3.4 for Windows.
The only issue I noticed is that the tcl and tk libraries included with CPython 3.4 are now ending with t, e.g. tcl86t.lib and tk86t.lib, not tcl86.lib and tk86.lib. See https://github.com/python-imaging/Pillow/blob/master/setup.py#L414.
There is a bug in Python 3.4 where the flag -Werror=declaration-after-statement is added for extension modules when it shouldn't, which cause the version of ImageDraw in my PR #610 to fail in compile-time if the workaround described in the Python issue isn't applied.
@hugovk That's in the windows build, and the deadsnakes ppa for Precise:
/usr/lib/python3.4/imp.py:32: PendingDeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
PendingDeprecationWarning)
Activity
hugovk commentedon Apr 2, 2014
Travis CI are in the process of adding 3.4: travis-ci/travis-ci#1989
Once it's ready, it can be added to .travis.yml. In fact, it could be added now as an allowed failure.
aclark4life commentedon Apr 2, 2014
Thanks @hugovk
cgohlke commentedon Apr 2, 2014
Pillow 2.4 passes all tests on CPython 3.4 for Windows.
The only issue I noticed is that the
tclandtklibraries included with CPython 3.4 are now ending witht, e.g.tcl86t.libandtk86t.lib, nottcl86.libandtk86.lib. See https://github.com/python-imaging/Pillow/blob/master/setup.py#L414.wiredfool commentedon Apr 4, 2014
I'm seeing that Py3.4 is triggering a PendingDeprecationWarning for the imp module, in favor of the importlib module.
hugovk commentedon Apr 9, 2014
@wiredfool Where is the
impmodule used by Pillow? I can't find it anywhere.Terseus commentedon Apr 9, 2014
There is a bug in Python 3.4 where the flag
-Werror=declaration-after-statementis added for extension modules when it shouldn't, which cause the version of ImageDraw in my PR #610 to fail in compile-time if the workaround described in the Python issue isn't applied.wiredfool commentedon Apr 18, 2014
@hugovk That's in the windows build, and the deadsnakes ppa for Precise:
I'm guessing it's the import calls in Image.py
wiredfool commentedon Apr 18, 2014
Apart from that, it's passing all the current tests for me.
hugovk commentedon Apr 30, 2014
Python 3.4 is now available on Travis CI and enabled for Pillow.
But imp's PendingDeprecationWarning is causing test failures because the test runner doesn't like print output. For example:
https://travis-ci.org/python-imaging/Pillow/jobs/24087446
hugovk commentedon May 8, 2014
The PendingDeprecationWarning is coming from Coverage.py, specifically
import coverageon line 348 of tester.py:https://github.com/python-imaging/Pillow/blob/master/Tests/tester.py#L348
Coverage.py, execfile.py, line 3,
import imp:https://github.com/nedbat/coveragepy/blob/master/coverage/execfile.py#L3
wiredfool commentedon May 8, 2014
We should just ignore that warning then, and revisit as coverage evolves. I'd like to make py3.4 a required passing test.
On Py3.4, a PendingDeprecationWarning comes from Coverage.py for usin…
Don't allow 3.4 failures
hugovk commentedon May 14, 2014
This issue can be closed.
Python 3.4 is now supported as a required passing build:
https://travis-ci.org/python-imaging/Pillow
I reported the warning to Coverage.py, and will update in another issue as needed.
aclark4life commentedon May 14, 2014
Thanks
hugovk commentedon May 17, 2014
Update: Ned Batchelder has fixed the imp warning in Coverage.py for Python 3.4:
Not yet released.