Repository navigation
Image.palette modified after calling show() or save() #718
Description
Activity
With regards to the saving of raw palette data, the same warning applies to the getcolor and tobytes method as well. Each time the code is as simple as -
if self.rawmode: raise ValueError("palette contains raw palette data")If the consensus is that any of these methods should be enabled for rawmode, and if there is confidence that the rawhide data isn't sufficiently different to cause problems, then it's just a matter of removing those lines.
Or alternatively can we close this and change the milestone to Never?
Reacted by Hugo van Kemenade
When an Image object is using palette, calling method Image.save() and Image.show() modifies Image.palette and Image.palette.save() throws an exception ValueError: palette contains raw palette data. The figure below shows the code and the exception. Please take a look at lines that commented out and the console output number 768.
After uncommenting the show() method, the exception disappeared, and the length of palette.palette was still 768.
But when I only use the save() method and comment out the show() method, the length will be 600, as I specified
colors=200before.I don't think a show() or save() method should modify the origin object, and I also think the palette of a converted palette picture should be able to save its palette directly, without saving or taking a glance at first.