Skip to content

Test coverage >= 90% #722

Description

@aclark4life

I'm not sure where the cutoff is, but it would be nice to get test coverage high enough to change the coveralls icon from red to not red. Currently we're at 72%.

Activity

  1. added this to the 2.5.0 milestone on Jun 25, 2014
  2. wiredfool commented on Jun 25, 2014

    @wiredfool
    Member

    It might even mean something if we could get meaningful measurements of the C coverage.

  3. hugovk commented on Jun 25, 2014

    @hugovk
    Member

    The Coveralls icon turns yellow at 80% and green at 90%.

    The easiest way to initially increase coverage will be to add tests for those with the lowest coverage. You click through on Coveralls to a build and see the files sorted by lowest coverage.

    C coverage would also be useful.

  4. modified the milestones: Future, 2.5.0 on Jun 28, 2014
  5. aclark4life commented on Jul 4, 2014

    @aclark4life
    MemberAuthor

    GO GO GO 75%

  6. aclark4life commented on Jul 30, 2014

    @aclark4life
    MemberAuthor

    GO @hugovk GO! 79%

  7. hugovk commented on Aug 4, 2014

    @hugovk
    Member

    And down from 79.37% to 73.57% when adding C coverage in #833, but gaining an additional 10,000 lines of instrumented code.

  8. aclark4life commented on Aug 4, 2014

    @aclark4life
    MemberAuthor

    Yep, best to take the hit now I guess.

  9. radarhere commented on Jan 29, 2017

    @radarhere
    Member

    The coveralls icon is now yellow, and says 80%!

  10. hugovk commented on Jan 29, 2017

    @hugovk
    Member

    Great!

    https://coveralls.io/builds/9892857 says 79.977%, rounded up to 80% for the badge.

    One last push and we can up the target to green 90% :)

  11. hugovk commented on Feb 19, 2017

    @hugovk
    Member

    https://coveralls.io/builds/10203543 now says 80.631%, rounded up to 81%!

    image

    Let's push onwards and upwards to 90% for a green!

  12. changed the title [-]Test coverage >= 80%[/-] [+]Test coverage >= 90%[/+] on Feb 19, 2017
  13. radarhere commented on Mar 31, 2019

    @radarhere
    Member

    As of #3637, we are now using the Codecov badge. Note that it does not have the same boundaries for the badge color. According to https://docs.codecov.io/docs/coverage-configuration, it will gradually transition from red at 70% to green at 100%.

  14. radarhere commented on Jan 24, 2020

    @radarhere
    Member

    90%!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions