Skip to content

Missing Apache-2.0 notice for IcoImagePlugin #8946

Description

@stefan6419846

What did you do?

Looked through the source code.

What did you expect to happen?

References to Apache-2.0 code contain the appropriate notice.

What actually happened?

The corresponding notice header is missing: https://github.com/python-pillow/Pillow/blob/main/src/PIL/IcoImagePlugin.py

In there, https://code.google.com/archive/p/casadebender/wikis/Win32IconImagePlugin.wiki is referenced, which is subject to the Apache-2.0 license:

Copyright 2008 Bryan Davis

Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions