Repository navigation
Missing TCL license in third-party licenses #9658
Description
Activity
There is nothing in the LICENSE file except Pillow's MIT-CMU license … are we supposed to include more licenses in there than just our license ? If so, this is the first I've heard of that.
When building the wheels, Pillow already includes a whole bunch of third-party licenses into the license file: https://github.com/python-pillow/Pillow/tree/main/wheels/dependency_licenses It seems like the TCL license is missing there.
By the way: If the tag you added means that I most likely used AI for my opening my latest issues, I can assure that your assumptions are wrong. This is not the first licensing-related issue I have opened on Pillow discovered during manual compliance reviews.
Reacted by Jeffrey 'Alex' ClarkWhen building the wheels, Pillow already includes a whole bunch of third-party licenses into the license file: https://github.com/python-pillow/Pillow/tree/main/wheels/dependency_licenses It seems like the TCL license is missing there.
Ah OK so we should include it there not in the top level LICENSE file, thank you.
By the way: If the tag you added means that I most likely used AI for my opening my latest issues, I can assure that your assumptions are wrong. This is not the first licensing-related issue I have opened on Pillow discovered during manual compliance reviews.
Apologies! Removed.
When building the wheels, Pillow already includes a whole bunch of third-party licenses into the license file
It may not make a difference, but I think there is a distinction to be made here. https://github.com/python-pillow/Pillow/tree/main/wheels/dependency_licenses contains licenses for software that is actually bundled and distributed with our wheels. We're not distributing Tcl wholesale, just
Line 1 in 9c1097c
I am aware that Tcl/Tk are not distributed in a whole, but only parts. Nevertheless, third-party code is distributed and/or compiled into the binaries shipped with Pillow, similar to the
raqmcode.
What did you do?
Reviewed distributed/bundled files.
What did you expect to happen?
Third-party code licenses are part of the LICENSE file.
What actually happened?
The license data from https://github.com/python-pillow/Pillow/blob/main/src/Tk/_tkmini.h is missing from the license file.
What are your OS, Python and Pillow versions?