Repository navigation
Conversation
Member
|
That's likely the approach we'd use on this. (+- the comments I've made on the duplicate code elsewhere). To add this, I'd like to see a compelling use case and documentation. |
radarhere
force-pushed
the
image_open
branch
from
September 10, 2015 13:14
5ab01d2 to
800555a
Compare
Member
Author
|
Ah, I'd forgotten that I'd included #1392 here. I've now removed that code from this branch, as that is a separate discussion. |
radarhere
force-pushed
the
image_open
branch
4 times, most recently
from
September 11, 2015 12:03
1125dd7 to
1fd3575
Compare
radarhere
force-pushed
the
image_open
branch
2 times, most recently
from
December 30, 2017 09:51
3ebbb98 to
710f9cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#569 requests the addition of a
format_argsargument to Image'sopenmethod, so that format-specific parameters can be set when creating the Image instance, as opposed to creating the Image instance, setting the parameters, and then callingload.This provides an example of how that API could be set up, without actually making use of the additional information.