Skip to content

Remove palettes from non-palette modes in _new #2702 - #2704

Merged
wiredfool merged 1 commit into
python-pillow:masterfrom
wiredfool:issue_2702
Aug 31, 2017
Merged

wiredfool merged 1 commit into
python-pillow:masterfrom
wiredfool:issue_2702

Conversation

@wiredfool

Copy link
Copy Markdown
Member

Fixes #2702

Changes proposed in this pull request:

  • Only copy the palette if new mode is in P, PA
  • Tests.

(note, making a 'PA' image via putalpha fails, so tests are somewhat incomplete)

@homm

homm commented Aug 31, 2017

Copy link
Copy Markdown
Member

Does this overlap #2633?

@wiredfool

Copy link
Copy Markdown
Member Author

It's the same underlying issue with a different variable. We could do the change for transparency here as well, as any of the *A modes shouldn't have a transparency entry.

@wiredfool
wiredfool merged commit 2ad43c4 into python-pillow:master Aug 31, 2017
@wiredfool
wiredfool deleted the issue_2702 branch October 2, 2017 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants