Repository navigation
Updated harfbuzz to 2.6.7 - #4696
Merged
Merged
Conversation
Contributor
|
This is probably what was causing the issues for the MinGW builds. Can you try removing the skip marks? |
Member
Author
|
Yep, ok, removed. |
Member
|
Thanks both! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that since harfbuzz 2.6.5, the test_imagefont test_variation_set_by_* tests started failing. Looking further, I find that it is just the assertions for AdobeVFPrototype.ttf that are failing, while TINY5x3GX.ttf passes.
Visually inspecting the difference, you get
Looking at the harfbuzz release notes for 2.6.5, my complete guess is that 'AAT is now always preferred for horizontal scripts when both AAT and OT layout tables exist at the same time.' might be culprit, AAT standing for Apple Advanced Typography while OT would be OpenType.
Rather than simply increase the epsilon to allow for the difference, I've created separate images in the test suite for before and after this change, accepting either as a passing test case.