Repository navigation
Test ImageChops.offset() with zero-size images - #9953
Merged
Merged
Conversation
Add regression coverage for zero-width and zero-height images, as requested during review of python-pillow#9847. Without that fix the remainder by zero in ImagingOffset dies with SIGFPE on x86-64. Co-Authored-By: Claude Fable 5.1 <[email protected]>
radarhere
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9847 fixed a remainder by zero in
ImagingOffsetfor zero-width or zero-height images. In review, @hugovk noted that the tests for(0, 1)and(1, 0)were missing from the PR; it merged with only theOffset.cchange. This adds them, following the zero-size parameterization already used inTests/test_image.py.Without the fix the test dies with SIGFPE on x86-64 (10/10 runs against
22c1ea2a); with it, 10/10 pass. On the arm64 build the undefined remainder by zero does not trap, so the pre-fix build passes there — theubuntu-latestandmacos-26-inteljobs are the ones that would catch a regression.