Skip to content

IP address is parsed into version number #474

Closed
Closed
IP address is parsed into version number#474
Labels
bugSomething isn't working properlystale

Description

@chbndrhnns
chbndrhnns
opened on Jul 20, 2022

The problem

My commit title is this:
'Use 127.0.0.1 as base_url for test client'

The output is this:

debug: parse_commit_message('fix: Use 127.0.0.1 as base_url for test client')
debug: parse_commit_message -> ParsedCommit(bump=1, type='fix', scope=None, descriptions=['Use 127.0.0.1 as base_url for test client'], breaking_descriptions=[])
debug: Commits found since last release: 2
debug: evaluate_version_bump -> patch
debug: get_new_version('4.28.3', '127.0.0', 'patch', False)

Expected behavior

The tool does not pick up an IP address for a version number

Additional context

Activity

  1. chbndrhnns
    added
    bugSomething isn't working properly
    on Jul 20, 2022

  2. github-actions commented on Aug 11, 2022

    @github-actions
    github-actionsbot
    on Aug 11, 2022

    This bug report has been labelled as help wanted since there has been no activity in the last 3 weeks. It will not be closed.

  3. github-actions
    added
    help-wantedExtra attention is required
    on Aug 11, 2022
  4. github-actions
    removed
    help-wantedExtra attention is required
    on Oct 23, 2022

  5. github-actions commented on Nov 13, 2022

    @github-actions
    github-actionsbot
    on Nov 13, 2022

    This bug report has been labelled as help wanted since there has been no activity in the last 3 weeks. It will not be closed.

  6. github-actions
    added
    help-wantedExtra attention is required
    and removed
    help-wantedExtra attention is required
    on Nov 13, 2022

  7. leonardo-saldanha-oxa commented on Dec 15, 2022

    @leonardo-saldanha-oxa
    leonardo-saldanha-oxa
    on Dec 15, 2022

    Any progress so far?

  8. bernardcooke53 commented on Dec 15, 2022

    @bernardcooke53
    bernardcooke53
    on Dec 15, 2022
    Contributor

    Hey - this should be fixed in the next major release

  9. leonardo-saldanha-oxa commented on Dec 16, 2022

    @leonardo-saldanha-oxa
    leonardo-saldanha-oxa
    on Dec 16, 2022

    Thanks for the prompt response, @bernardcooke53 ! Looking forward to it

  10. github-actions commented on Mar 26, 2024

    @github-actions
    github-actionsbot
    on Mar 26, 2024 – with GitHub Actions

    This issue is stale because it has not been confirmed or planned by the maintainers and has been open 90 days with no recent activity. It will be closed in 7 days, if no further activity occurs. Thank you for your contributions.

  11. github-actions
    added
    stale
    on Mar 26, 2024

  12. chbndrhnns commented on Mar 26, 2024

    @chbndrhnns
    chbndrhnns
    on Mar 26, 2024
    Author

    @bernardcooke53 can you tell if this fix has been included in the release you mentioned?

  13. codejedi365 commented on Mar 26, 2024

    @codejedi365
    codejedi365
    on Mar 26, 2024
    Contributor

    can you tell if this fix has been included in the release you mentioned?

    @chbndrhnns, as of v8 (July 16, 2023), commit messages are no longer used to extract version numbers, only tags are used. I reviewed the code again to confirm. The commit messages are evaluated for other indicators to determine which new version number will be created based on the commit parser chosen. With this said, I believe that your issue will no longer occur.

  14. chbndrhnns
    closed this as completedon Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working properlystale

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions