Skip to content

Hardcoded v-prefix in changelog #561

Closed
Closed
Hardcoded v-prefix in changelog#561
Labels
fixed-in-v8Issues which will be or are fixed in PSR v8question

Description

@afuetterer
afuetterer
opened on Feb 23, 2023

Hi there, I just recently started using this great library.

I set the tag_format to {version} without the v-prefix.

[tool.semantic_release]
# ...
tag_format = "{version}"

In the changelog headers however there is a hardcoded v-prefix.

# Changelog

All notable changes to this project will be documented in this file.

## v0.7.1 (2023-02-19)
### Fix
...

There is no way to disable this via another setting, right?

Any help would be appreciated. Thank you.

Activity

  1. afuetterer
    added
    question
    on Feb 23, 2023

  2. bernardcooke53 commented on Feb 24, 2023

    @bernardcooke53
    bernardcooke53
    on Feb 24, 2023
    Contributor

    Hey @afuetterer - I don't think there is a way to disable this setting currently, for example it is hardcoded here.

    This should be possible in the upcoming major version - you can try it out yourself with pip install --upgrade --pre python-semantic-release 🙂

  3. bernardcooke53
    added
    fixed-in-v8Issues which will be or are fixed in PSR v8
    on Feb 24, 2023

  4. afuetterer commented on Feb 25, 2023

    @afuetterer
    afuetterer
    on Feb 25, 2023
    ContributorAuthor

    Hi @bernardcooke53, thanks for taking the time to answer me.
    That is great news. v8 looks awesome. I will try the pre-release soon.

  5. afuetterer
    closed this as completedon Feb 25, 2023

  6. afuetterer commented on Feb 27, 2023

    @afuetterer
    afuetterer
    on Feb 27, 2023
    ContributorAuthor

    Hi @bernardcooke53, I tried the pre-release. What is the best way to give feedback on things I discover? If I understood the configuration correctly, some things don't work as expected.

  7. afuetterer
    reopened this on Feb 27, 2023

  8. afuetterer commented on Feb 27, 2023

    @afuetterer
    afuetterer
    on Feb 27, 2023
    ContributorAuthor

    For example: Using the pre-release v8.0.0-alpha.3 seems to not take into account the tag_format specified in pyproject.toml, when tagging and releasing?

    tag_format = "{version}"

    See my config in https://github.com/afuetterer/minimal-example

    It tagged and released v0.1.0, instead of 0.1.0. Or am I doing something wrong here?

  9. bernardcooke53 commented on Feb 27, 2023

    @bernardcooke53
    bernardcooke53
    on Feb 27, 2023
    Contributor

    Probably best to take other bugs to #487 - thanks for testing it out and for sharing the minimal example, I have used your repo locally to test it out and that should now be fixed in v8.0.0-alpha.4 🤞

  10. afuetterer commented on Feb 28, 2023

    @afuetterer
    afuetterer
    on Feb 28, 2023
    ContributorAuthor

    Excellent, thank you very much for your reply.
    I tried alpha.4, the fix works and minmal-example gets tagged with the specified tag_format.

    I will report other links in #487 as suggested.

  11. afuetterer
    closed this as completedon Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixed-in-v8Issues which will be or are fixed in PSR v8question

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions