Repository navigation
Underscores in URLs seem to break the validator #102
Description
URLs can have underscores in the subdomain and be valid. https://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it URLs with underscores are incorrectly identified as not being URLs.
Example of the failure :
>>> validators.url("https://sample_subdomain.example.com")
ValidationFailure(func=url, args={'value': 'https://sample_subdomain.example.com', 'public': False})
>>> validators.url("https://sample-subdomain.example.com")
True
Activity
chalbersma commentedon Dec 5, 2018
I'm not sure where exactly this would need to be added to the pattern but I assume it's somewhere here : https://github.com/kvesteri/validators/blob/master/validators/url.py#L74
maint: improves `url` module