Skip to content

Naming of train/evaluate #168

Description

@colesbury

This is admittedly some bike-sheding, but typically when programming with objects, method names (especially ones that change state) are verbs and attributes are nouns.

With train/eval mode we completely swapped this: the methods (training() evaluation()) are nouns and the attribute (self.train) is a verb.

We should fix this before release. Either:

  • Use a python property and get rid of the methods
  • Use verbs or abbreviations for the methods (i.e train() eval())

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    todoNot as important as medium or high priority tasks, but we will work on these.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions