Repository navigation
Clean up Module forward and __call__ - #14
Merged
Merged
Conversation
* _forward is renamed forward since users should override it * some __call__ overrides are changed to forward * function which return a single variable are changed to return that variable instead of a one-element tuple
yogi81
referenced
this pull request
Aug 16, 2017
zou3519
referenced
this pull request
in zou3519/pytorch
May 23, 2018
This was referenced Jan 9, 2019
Closed
6 tasks done
This was referenced Jun 26, 2026
This was referenced Jul 27, 2026
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__call__overrides are changed to forwardvariable instead of a one-element tuple