Add Storage.from_buffer - #9
Merged
Merged
Conversation
Collaborator
| THPByteOrder byte_order; | ||
| if (strcmp(byte_order_str, "native") == 0) { | ||
| byte_order = THP_nativeByteOrder(); | ||
| } else if (strcmp(byte_order_str, "be") == 0) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
|
ok tests pass. @apaszke good to go? |
Contributor
|
It still gives some compiler warnings. @colesbury could you please take a look? |
Contributor
Author
|
(Fixed build warning) |
The from_buffer is similar to numpy's frombuffer. It decodes a Python buffer object into a Storage object. For byte and char storages, it simply copies the bytes.
Contributor
Author
|
I have no idea what I'm doing |
This was referenced Jun 26, 2026
This was referenced Jul 27, 2026
This was referenced Jul 31, 2026
This was referenced Aug 1, 2026
This was referenced Aug 8, 2026
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The from_buffer is similar to numpy's frombuffer. It decodes a Python
buffer object into a Storage object. For byte and char storages, it
simply copies the bytes.