Skip to content

Build with ffmpeg only on Linux - #4463

Closed
prabhat00155 wants to merge 1 commit into
pytorch:release/0.10from
prabhat00155:prabhat00155/fix_segfault
Closed

prabhat00155 wants to merge 1 commit into
pytorch:release/0.10from
prabhat00155:prabhat00155/fix_segfault

Conversation

@prabhat00155

Copy link
Copy Markdown
Contributor

No description provided.

@bjuncek

bjuncek commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Hmm.
wouldn't we want to be able to build it on a macOS?
If I understand correctly, the linking segfault is gone when pytorch is compiled from source; maybe we can just add that to the documentation?

Or even better, maybe add a flag that would be off by default (on a mac or not) so that we can do
WITH_FFMPEG=1 python setup.py isntall

@prabhat00155

Copy link
Copy Markdown
Contributor Author

Hmm.
wouldn't we want to be able to build it on a macOS?
If I understand correctly, the linking segfault is gone when pytorch is compiled from source; maybe we can just add that to the documentation?

Or even better, maybe add a flag that would be off by default (on a mac or not) so that we can do
WITH_FFMPEG=1 python setup.py isntall

This PR is against the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants