WeightsEnum.get_state_dict: fix return type - #9286

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9286

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• B200 runners are down due to network issues

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Thanks for the PR, CI has been disabled so I can't validate the changes for now - feel free to ping again in a few days.

Out of curiosity though, what's the actual value of changing the type from Mapping to dict? It's more specific, but why is it better? This is a genuine question, I'm not trying to be snarky.

Mapping supports __getitem__, but does not support __setitem__ (docs). In our case (TorchGeo), we want to be able to later insert more values into this dictionary. The type checker is currently complaining that this isn't allowed.

@NicolasHug anything else needed to merge this PR?

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

Looks like this didn't make it into 0.25.0. Will it automatically be added to the next release?

Yes, it'll be part of the next one