Skip to content

Port CPU read_file and write_file to stable ABI. - #9549

Merged
NicolasHug merged 1 commit into
mainfrom
adabeyta/read-write-file-stable
Jul 10, 2026
Merged

Port CPU read_file and write_file to stable ABI.#9549
NicolasHug merged 1 commit into
mainfrom
adabeyta/read-write-file-stable

Conversation

@adabeyta

@adabeyta adabeyta commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Ports CPU read_file and write_file to stable ABI reusing image_stable extension.

Notes: Missing StableABI from_file op

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit against the built torchvision package.

image_stable.so audits as STABLE — 72 stable-shim symbols, 0 unstable The legacy image.so drops 45 → 43 unstable.

  Package: torchvision
    Torch ABI:   UNSTABLE
    CPython ABI: n/a
    Bundled libs: 4
    -- bundled libs --
      [UNSTABLE] [not-abi3        ] _C.so            (stable_shim=0,  unstable=110)
      [STABLE  ] [not-abi3        ] _C_stable.so     (stable_shim=67, unstable=0)
      [UNSTABLE] [uses-private-api] image.so         (stable_shim=0,  unstable=43)
      [STABLE  ] [not-abi3        ] image_stable.so  (stable_shim=72, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9549

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure, 1 Unclassified Failure

As of commit 3f93bf2 with merge base 66089cf (image):

NEW FAILURE - The following job has failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Jul 9, 2026
@adabeyta
adabeyta force-pushed the adabeyta/read-write-file-stable branch from 7ed17ff to 3f93bf2 Compare July 9, 2026 20:49
@adabeyta adabeyta changed the title [Test] Port CPU read_file and write_file to stable ABI. Port CPU read_file and write_file to stable ABI. Jul 10, 2026
@adabeyta
adabeyta marked this pull request as ready for review July 10, 2026 00:25
@adabeyta
adabeyta requested a review from NicolasHug July 10, 2026 00:25
NicolasHug
NicolasHug approved these changes Jul 10, 2026
View reviewed changes

@NicolasHug NicolasHug left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adabeyta

@NicolasHug
NicolasHug merged commit b9e9552 into main Jul 10, 2026
59 of 63 checks passed
@NicolasHug
NicolasHug deleted the adabeyta/read-write-file-stable branch July 10, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adabeyta @NicolasHug