Skip to content

Port CPU decode_webp to stable ABI and retire the unstable image extension - #9557

Merged
NicolasHug merged 1 commit into
mainfrom
adabeyta/decode-webp-stable
Jul 16, 2026
Merged

NicolasHug merged 1 commit into
mainfrom
adabeyta/decode-webp-stable

Conversation

@adabeyta

@adabeyta adabeyta commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Ports CPU webp decoder to stable ABI and retires the unstable image extension. Every image op now registers from image_stable.

Notes

  • decode_webp is the last unstable image op.
  • Unstable extension retirement: image.cpp/image.h and common.{h,cpp} are deleted, make_image_extension() and the _stable() source partition go away.
  • ROCm: hipify's generated copy of the nvJPEG TU now links alongside the committed rocJPEG decoder, so the nvJPEG TU is guarded with #if !ROCJPEG_FOUND and the rocJPEG decoder registers its own schema.

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit. The io/image migration is complete: image.so is gone, and image_stable.so audits as STABLE — 76 stable-shim symbols, 0 unstable.

    Package: torchvision
      Torch ABI:   UNSTABLE
      CPython ABI: n/a
      Bundled libs: 3
      -- bundled libs --
        [UNSTABLE] [not-abi3        ] _C.so            (stable_shim=0,  unstable=110)
        [STABLE  ] [not-abi3        ] _C_stable.so     (stable_shim=67, unstable=0)
        [STABLE  ] [not-abi3        ] image_stable.so  (stable_shim=76, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9557

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Unclassified Failure

As of commit c217a9d with merge base 3aadb2d (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Jul 15, 2026
@adabeyta
adabeyta force-pushed the adabeyta/decode-webp-stable branch from d9a32ff to c217a9d Compare July 16, 2026 01:40
@adabeyta adabeyta changed the title [Test] Port CPU decode_webp to stable ABI and retire the unstable image extension Port CPU decode_webp to stable ABI and retire the unstable image extension Jul 16, 2026
@adabeyta
adabeyta marked this pull request as ready for review July 16, 2026 04:00
@adabeyta
adabeyta requested a review from NicolasHug July 16, 2026 04:00

@NicolasHug NicolasHug left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work @adabeyta !

torch::Tensor decode_webp(
const torch::Tensor& encoded_data,
namespace {
bool should_this_return_rgb_or_rgba_let_me_know_in_the_comments_down_below_guys_see_you_in_the_next_video(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preserving the name 😆

@adabeyta adabeyta Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need an answer in the comments 😉

@NicolasHug
NicolasHug merged commit f23f832 into main Jul 16, 2026
60 checks passed
@NicolasHug
NicolasHug deleted the adabeyta/decode-webp-stable branch July 16, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants